ObjectBuilder Work Item Rss Feed

Closed Issue: n-deep Containers Not Supported [13636]

BradWilson — Thu, 16 May 2013 07:10:24 GMT

Trying to embed containers multiple levels deep doesn't work because staged strategy chain does not properly consult the parent strategy chain.

Closed Issue: Bug in ParametersToTypeList method of the BuilderStrategy class [14140]

BradWilson — Thu, 16 May 2013 07:10:23 GMT

I found a bug in the ParametersToTypeList method of the BuilderStrategy class. Inside the method it execute "parameter.GetType().Name". This does not take into account that "parameter" can be null, causing a exeception. This bug was exposed when I used a SCSF service with a constructor as follows:

MyService([ServiceDependency] IOtherService s1, [ServiceDependency(Required=false)] IAnotherService s2)

The second parameter is not required and can thus be null. These two parameters is eventually passed into the ParametersToTypeList function where the second entry in the array is null, causing the exception. The fix for the bug is as follows:

/// <summary>
/// Creates a trace list of parameter types from a list of <see cref="IParameter"/> objects.
/// </summary>
/// <param name="parameters">The parameters</param>
/// <returns>The type list in string form</returns>
protected string ParametersToTypeList(params object[] parameters)
{
List<string> types = new List<string>();

foreach (object parameter in parameters)
{
if (parameter != null)
types.Add(parameter.GetType().Name);
else
types.Add("null");
}

return string.Join(", ", types.ToArray());
}

Commented Issue: Using custom Parameter Attribute gives Key Not Found in Dictionary Exception

jatindua — Wed, 29 Apr 2009 00:42:50 GMT

Hi There,

We have developed our own custom attribute similiar to the CreateNew attribute in WCSF. We have called it CreateNewOnce so that within an HTTPContext, an object of a particular type is created just once, no matter how many times its property is accessed. I have attached the code below. Now, this worked perfectly in Microsoft.Practices.CompositeWeb.EnterpriseLibrary v 2.0.0.0 but in the new 3.5 version it gives a Key Not found Exception. I have pasted the exception below as well. Its almost as if the Object Builder is unaware of the CreateNewOnce attribute. Do we need to register it somewhere to let Object Builder know of its existance. I would have thought inherting from Parameter Attribute should do that for us. What has changed in the new Object Builder version?

Any help will be greatly apreciated. The code breaks at public CreateNewOnceAttribute() { }

Thanks Jatin

Error:
[KeyNotFoundException: The given key was not present in the dictionary.]

System.ThrowHelper.ThrowKeyNotFoundException() +28

System.Collections.Generic.Dictionary`2.get_Item(TKey key) +7452124

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.DynamicMethodPlan.Parameters.ParameterResolverMap.GetResolver(ParameterAttribute resolutionAttribute) +77

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.DynamicMethodPlan.Properties.SetPropertiesStrategy.EmitResolveProperty(ILGenerator il, PropertyInfo prop) +87

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.DynamicMethodPlan.Properties.SetPropertiesStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild, ILGenerator il) +395

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.DynamicMethodPlan.PlanBuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +105

Microsoft.Practices.ObjectBuilder.BuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +38

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.DynamicMethodPlan.PlanBuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +126

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.DynamicMethodPlan.DynamicMethodPlanBuilderPolicy.CreatePlan(Type typeToBuild, String idToBuild) +372

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.BuildPlanStrategy.GetPlanFromContext(IBuilderContext context, Type typeToBuild, String idToBuild) +157

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.BuildPlanStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +51

Microsoft.Practices.ObjectBuilder.BuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +38

Microsoft.Practices.CompositeWeb.ObjectBuilder.Strategies.SimplifiedSingletonStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +245

Microsoft.Practices.ObjectBuilder.BuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +38

Microsoft.Practices.ObjectBuilder.TypeMappingStrategy.BuildUp(IBuilderContext context, Type t, Object existing, String id) +278

Microsoft.Practices.ObjectBuilder.BuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +38

Microsoft.Practices.CompositeWeb.BuilderStrategies.ContainerAwareTypeMappingStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +255

BuildUp_ASP.modules_inbox_inbox_aspx(IBuilderContext , Type , Object , String ) +171

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.DynamicMethodPlan.DynamicMethodBuildPlan.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String id) +63

Microsoft.Practices.CompositeWeb.ObjectBuilder.BuildPlan.BuildPlanStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +81

Microsoft.Practices.ObjectBuilder.BuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +38

Microsoft.Practices.CompositeWeb.ObjectBuilder.Strategies.SimplifiedSingletonStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +245

Microsoft.Practices.ObjectBuilder.BuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +38

Microsoft.Practices.ObjectBuilder.TypeMappingStrategy.BuildUp(IBuilderContext context, Type t, Object existing, String id) +278

Microsoft.Practices.ObjectBuilder.BuilderStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +38

Microsoft.Practices.CompositeWeb.BuilderStrategies.ContainerAwareTypeMappingStrategy.BuildUp(IBuilderContext context, Type typeToBuild, Object existing, String idToBuild) +289

Microsoft.Practices.CompositeWeb.ObjectBuilder.WCSFBuilderBase`1.DoBuildUp(IReadWriteLocator locator, Type typeToBuild, String idToBuild, Object existing, PolicyList[] transientPolicies) +139

Microsoft.Practices.CompositeWeb.ObjectBuilder.WCSFBuilderBase`1.BuildUp(IReadWriteLocator locator, Type typeToBuild, String idToBuild, Object existing, PolicyList[] transientPolicies) +55

Microsoft.Practices.CompositeWeb.CompositionContainer.BuildItem(IBuilder`1 builder, IReadWriteLocator locator, Object item) +411

Microsoft.Practices.CompositeWeb.WebClientApplication.BuildItemWithCurrentContext(Object obj) +187

Microsoft.Practices.CompositeWeb.Web.UI.Page.OnPreInit(EventArgs e) +47

System.Web.UI.Page.PerformPreInit() +31

System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +282
Comments: ** Comment from web user: jatindua **

Sorry the Impact is High not Low...

Created Issue: Using custom Parameter Attribute gives Key Not Found in Dictionary Exception

jatindua — Wed, 29 Apr 2009 00:33:58 GMT

CREATED ISSUE: Create objects through a static method call

yurik — Wed, 13 Feb 2008 17:38:17 GMT

There is a large number of libraries (including the framework itself), that uses a static method call on a factory class to create an instance of an object. I am in process of creating such strategy that will take a type, a method name, and a list of parameters, and use them to get a desired object.

COMMENTED ISSUE: Injecting COM objects throws an exception

yurik — Wed, 13 Feb 2008 17:33:16 GMT

Hi Guys,

ObjectBuilding my way through the visual studio IDE I ran into a problem when injecting Com-objects (such as the realization EnvDTE.DTE).

problem occurs when creating an object that gets an COM-object injected in its constructor.

Problem boils down to the Guard.TypeIsAssignableFromType throwing an exception if the found type is not assignablable from the constructor-paramters type.

if (!assignee.IsAssignableFrom(providedType))
throw new IncompatibleTypesException(....);

My workaround (the quickest, problably not the best -but here to provide insight on the issue)

if (!providedType.IsCOMObject)
if (!assignee.IsAssignableFrom(providedType))
throw new IncompatibleTypesException(....);
Comments: ** Comment from web user: yurik **

I ran into a similar problem, but with remoting objects. My solution was to add
&& providedType != typeof(MarshalByRefObject)
to the Guard.TypeIsAssignableFromType(), which solved it for any objects created through remoting.

COMMENTED ISSUE: Bug in ParametersToTypeList method of the BuilderStrategy class

BradWilson — Sun, 23 Dec 2007 20:07:43 GMT

Fixed in change set 29324

COMMENTED ISSUE: Bug in ParametersToTypeList method of the BuilderStrategy class

BradWilson — Sat, 01 Dec 2007 17:44:01 GMT

This method isn't current used in OB 2, so I'm just going to remove it.

CREATED ISSUE: Bug in ParametersToTypeList method of the BuilderStrategy class

fgretief — Wed, 28 Nov 2007 08:34:40 GMT

CREATED FEATURE: Adapt CAB's WorkItem

BradWilson — Thu, 08 Nov 2007 22:06:53 GMT

Hi,

I really would like to see sample code or documentation on adopting the new ObjectBuilder within CAB WorkItem.
Something like what to change in ManagedObjectCollection etc. to use the new ObjectBuilder.

The reason why asking about this is that we build our own company's framework on top of CAB and would like the use the new features, bugfixes, and improvements of ObjectBuilder.

That would be cool
-Matthias

COMMENTED ISSUE: n-deep Containers Not Supported

BradWilson — Thu, 01 Nov 2007 21:26:13 GMT

Trying to embed containers multiple levels deep doesn't work because staged strategy chain does not properly consult the parent strategy chain.
Comments: ** Comment from web user: BradWilson **

Fixed in change set 28159.

CREATED ISSUE: n-deep Containers Not Supported

BradWilson — Thu, 01 Nov 2007 21:25:30 GMT

Trying to embed containers multiple levels deep doesn't work because staged strategy chain does not properly consult the parent strategy chain.

COMMENTED ISSUE: Serious need for documentation

RJanzen — Thu, 25 Oct 2007 10:23:27 GMT

It's about time we get an documentation, at least version 2 should have this upon release.
Comments: ** Comment from web user: RJanzen **

I would be happy with a good documentation.

CREATED FEATURE: EventBroker enhancements

BradWilson — Sat, 15 Sep 2007 22:58:43 GMT

I would love to see a strategy for event raising.

Event Raising can be done sequentially or in parallel.

It can also be stopped after an handler throws an exception or cumulate the exceptions and throw the sum of all exceptions at the end.

This strategy could be controlled by attributes on the event source.

COMMENTED ISSUE: Interception Refactorings

BradWilson — Thu, 16 Aug 2007 16:08:27 GMT

Much stuff is shared between ILEmitProxy and RemotingProxy. I would see stuff being extracted into a shared class.

- The Handlers Dictionary.
- Almost all of the Invoke method implementation

Same with InterfaceInterceptionStrategy and VirtualInterceptionStrategy, I would extract an ILEmitInterceptionStrategy base class
- BuildUp implementation
- Even Intercept* has common stuff

BTW, do you mind we propose refactorings?
Comments: ** Comment from web user: BradWilson **

We were definitely headed in that direction, but we appreciate the nudge! :)

CREATED ISSUE: Just implement Windsor features

evarlast — Thu, 16 Aug 2007 13:53:03 GMT

bug: ObjectBuilder isn't as "awesome" as Windsor. Just implement Windsor features.

CREATED ISSUE: Interception Refactorings

francois_tanguay — Thu, 09 Aug 2007 16:42:18 GMT

COMMENTED TASK: Autowrapping interceptor for WinForms Threading

francois_tanguay — Thu, 09 Aug 2007 13:46:18 GMT

See http://www.agileprogrammer.com/dotnetguy/archive/2006/11/22/21274.aspx for details.
Comments: ** Comment from web user: francois_tanguay **

FYI, I was planning to add a SynchronizedCallHandler to EntLibContrib. It would work with ISynchornizeInvoke so that when the target is either a Control or a View implementing the same interface, it would get invoked correctly if InvokeRequired. Any thoughts?

COMMENTED ISSUE: Serious need for documentation

rrudracodeplex — Thu, 09 Aug 2007 05:50:43 GMT

It's about time we get an documentation, at least version 2 should have this upon release.
Comments: ** Comment from web user: rrudracodeplex **

It appears that lot of work is going into this project since last couple of months from source code monitoring. Documentation is the key to get people on board.

COMMENTED ISSUE: Serious need for documentation

DevilDog74 — Sun, 29 Jul 2007 20:31:40 GMT

It's about time we get an documentation, at least version 2 should have this upon release.
Comments: ** Comment from web user: DevilDog74 **

I would be happy with a simple example of how to use the CreateNew attribute